Closed
Conversation
Author
There was a problem hiding this comment.
Wasn't completely sure on the dual-licensing of this file, this was the only place that the exact same patch did not apply cleanly.
Owner
|
Thanks for the patch. I didn't apply it at the time because I was trying to decide whether to switch to MIT exclusively or dual license and then got busy. In the end I think dual license is better because it provides people with better guarantees but allows used with Apache-2.0 incompatible software. Because I ended up going with a dual license, I ended up doing the patch myself. Sorry it took so long for me to get around to this! |
Author
|
Dual-licensing works great too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You've already gotten permission to relicense the changes from #3 (comment), what about the small change from PR #2?